Remove _ENV_CONFIG and cached env config to config.py#3208
Open
jx2lee wants to merge 4 commits intoapache:mainfrom
Open
Remove _ENV_CONFIG and cached env config to config.py#3208jx2lee wants to merge 4 commits intoapache:mainfrom
jx2lee wants to merge 4 commits intoapache:mainfrom
Conversation
jx2lee
force-pushed
the
jx2lee/remove-global-var
branch
from
68c1316 to
8789abe
Compare
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that's incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #3028
and Related #3083
Rationale for this change
Move the cached environment config out of
pyiceberg.catalogintopyiceberg.utils.configso catalog loading no longer depends on a module-level mutable global and tests can patch config access more cleanly.Are these changes tested?
Yes, updated the affected catalog, CLI, and config tests.
Are there any user-facing changes?
No.